Re: [PATCH v2 4/4] Staging: Lustre Fix block statement style issue

[Dilger, Andreas]

On Jul 12, 2017, at 03:03, Craig Inches <craig@xxxxxxxxxxxxxxx> wrote:
> 
> This fixes a block statement which didnt end with */
> 
> Signed-off-by: Craig Inches <Craig@xxxxxxxxxxxxxxx>
> ---
> drivers/staging/lustre/include/linux/lnet/socklnd.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/include/linux/lnet/socklnd.h b/drivers/staging/lustre/include/linux/lnet/socklnd.h
> index dd5bc0e46560..a1ae66ede7a8 100644
> --- a/drivers/staging/lustre/include/linux/lnet/socklnd.h
> +++ b/drivers/staging/lustre/include/linux/lnet/socklnd.h
> @@ -76,7 +76,8 @@ struct ksock_msg {
> 	__u64	ksm_zc_cookies[2];	/* Zero-Copy request/ACK cookie */
> 	union {
> 		struct ksock_lnet_msg lnetmsg; /* lnet message, it's empty if
> -					  * it's NOOP */
> +						* it's NOOP
> +						*/

Rather than making the multi-line comments even more space consuming (I'm not a big
fan of "*/ must be on a line by itself" since it wastes a lot of vertical space),
I'd prefer to just shorten the comment, if possible, like:

		struct ksock_lnet_msg lnetmsg; /* lnet message, empty if NOOP */

Cheers, Andreas
--
Andreas Dilger
Lustre Principal Architect
Intel Corporation