Re: [PATCH 1/5] staging/pi433:Removed Coding style issues from pi433_if.h and other dependencies arising from it.
From: Dan Carpenter
Date: Wed Aug 02 2017 - 05:33:26 EST
On Wed, Aug 02, 2017 at 11:15:16AM +0200, Wolf Entwicklungen wrote:
> Hi Dan,
> I offered Greg to have an eye on the patches, that were submitted. He asked
> me to reply to those patches, I had a look for, with the Reviewed-by tag.
> Now I am a bit unsure, what I should do.
> Since I am interested in, I for sure will read every patch. It's just a little
> thing, to reply with reviewed-tag - if you / Greg like(s). I can do so on every
> reviewed patch, only on patches without need/wish of improvement or never.
> Compiling every patch is a bit inconvenient.
> Please let me know, what you and Greg would like.
That's fine, you don't need to build test them if you don't want to.
Greg is going to do it.
But in this case, it was pretty obvious that it was going to break git
bisect right? That's not allowed. You're not expected to know all the
rules when you start so that's fine. I'm just trying to give you some
ideas what to look for in the future.