Re: [PATCH v3 28/28] drm: vboxvideo: switch to drm_*_get(), drm_*_put() helpers

[Daniel Vetter]

On Fri, Aug 11, 2017 at 06:11:08PM +0200, Hans de Goede wrote:
> Hi,
> 
> On 11-08-17 18:04, Sean Paul wrote:
> > On Fri, Aug 11, 2017 at 03:26:45PM +0200, Hans de Goede wrote:
> > > Hi,
> > > 
> > > On 11-08-17 14:33, Cihangir Akturk wrote:
> > > > Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference()
> > > > and drm_*_unreference() helpers.
> > > > 
> > > > drm_*_reference() and drm_*_unreference() functions are just
> > > > compatibility alias for drm_*_get() and drm_*_put() and should not be
> > > > used by new code. So convert all users of compatibility functions to
> > > > use the new APIs.
> > > > 
> > > > Generated by: scripts/coccinelle/api/drm-get-put.cocci
> > > > 
> > > > Signed-off-by: Cihangir Akturk <cakturk@xxxxxxxxx>
> > > 
> > > Thank you for doing this, looks good to me:
> > > 
> > > Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> > > 
> > 
> > Applied to drm-misc-next, thank you for the review!
> 
> Erm vboxvideo is in staging, does this mean all patches for
> it will now go through drm-misc-next despite it being in
> staging (*) ?  Because if some patches get merged through
> drm-misc-next and some through Greg's staging repo that
> is not going to end well.

-staging doesn't work for drm. And yes this patch needs to go in through
drm-misc I think (I don't want to be at Greg's mercy for merging cleanups,
same way we don't wait for driver maintainers if they don't merge the
patch in a timely fashion).

I'd say if no one is actually working on vbox cleanup (i.e. porting to
atomic) we'll throw it out next cycle again.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch