Re: [PATCH v3 1/3] irq/irq_sim: add a simple interrupt simulator framework
From: Bartosz Golaszewski
Date: Mon Aug 14 2017 - 10:49:29 EST
2017-08-14 16:48 GMT+02:00 Thomas Gleixner <tglx@xxxxxxxxxxxxx>:
> On Mon, 14 Aug 2017, Bartosz Golaszewski wrote:
>> 2017-08-14 15:06 GMT+02:00 Thomas Gleixner <tglx@xxxxxxxxxxxxx>:
>> > On Mon, 14 Aug 2017, Bartosz Golaszewski wrote:
>> >
>> >> Implement a simple, irq_work-based framework for simulating
>> >> interrupts. Currently the API exposes routines for initializing and
>> >> deinitializing the simulator object, enqueueing the interrupts and
>> >> retrieving the allocated interrupt numbers based on the offset of the
>> >> dummy interrupt in the simulator struct.
>> >>
>> >> Signed-off-by: Bartosz Golaszewski <brgl@xxxxxxxx>
>> >> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
>> >> ---
>> >> include/linux/irq_sim.h | 44 ++++++++++++++++++
>> >> init/Kconfig | 4 ++
>> >> kernel/Makefile | 1 +
>> >> kernel/irq_sim.c | 121 ++++++++++++++++++++++++++++++++++++++++++++++++
>> >
>> > Please move this to kernel/irq/ ... and the config option to kernel/irq/Kconfig.
>> >
>> > Thanks,
>> >
>> > tglx
>> >
>> >
>>
>> How about moving irq_work.c there too?
>
> We could, but irq_work is not really part of the interrupt subsystem, while
> your interrupt simulator definitely is.
>
Fair enough, let's leave it where it is.
I'll send v4.
Thanks,
Bartosz