Re: [PATCH 1/2] watchdog: cadence_wdt: Enable access to module parameters

From: Michal Simek
Date: Mon Aug 14 2017 - 10:51:52 EST


On 14.8.2017 16:47, Guenter Roeck wrote:
> On Fri, Aug 04, 2017 at 09:39:16AM +0200, Michal Simek wrote:
>> Give read access to module parameters to all and write access to root.
>> This change also improves driver error path testing.
>>
>> Signed-off-by: Michal Simek <michal.simek@xxxxxxxxxx>
>
> Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>
>
>> ---
>>
>> Please let me know what you think - I can use macros from stat.h if
>> required
>>
> You mean instead of 0644 ? That is discouraged nowadays.

yep and good.

Thanks,
Michal