Re: [PATCH v3 3/5] reset: stm32: use the reset-simple driver
From: Eugeniy Paltsev
Date: Wed Aug 16 2017 - 08:52:14 EST
Hi Philipp,
On Wed, 2017-08-16 at 11:46 +0200, Philipp Zabel wrote:
> The reset-simple driver can be used without changes.
>
> Signed-off-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> [snip]
>
> --- a/drivers/reset/reset-simple.c
> +++ b/drivers/reset/reset-simple.c
> @@ -120,6 +120,7 @@ static const struct reset_simple_devdata
> reset_simple_active_low = {
> Â
> Âstatic const struct of_device_id reset_simple_dt_ids[] = {
> Â { .compatible = "altr,rst-mgr", .data =
> &reset_simple_socfpga },
> + { .compatible = "st,stm32-rcc", },
> Â { .compatible = "allwinner,sun6i-a31-clock-reset",
> Â .data = &reset_simple_active_low },
> Â { /* sentinel */ },
What about adding generic compatible strings for future use?
I mean next:
--------------------->8---------------------
static const struct of_device_id reset_simple_dt_ids[] = {
{ .compatible = "reset-simple-active-low",
.data = &reset_simple_active_low },
{ .compatible = "reset-simple-active-high",
.data = &reset_simple_active_high },
/* ... */
{ /* sentinel */ },
};
static const struct reset_simple_devdata reset_simple_active_high = {
.active_low = false,
};
static const struct reset_simple_devdata reset_simple_active_low = {
.active_low = true,
};
--------------------->8---------------------
--
ÂEugeniy Paltsev