Re: [PATCH] tools: fix compile error of freq-step.c
From: Shuah Khan
Date: Wed Aug 16 2017 - 14:50:04 EST
On 08/16/2017 12:27 PM, John Stultz wrote:
> On Tue, Aug 15, 2017 at 11:08 PM, Thomas Richter
> <tmricht@xxxxxxxxxxxxxxxxxx> wrote:
>> The compilation of the file freq-step.c in directory
>> tools/testing/selftests/timers fails with this error message:
>>
>> [root@s8360046 timers]# make
>> gcc -O3 -Wl,-no-as-needed -Wall -DKTEST -lrt -lpthread -lm freq-step.c
>> -o freq-step
>> freq-step.c: In function âinit_testâ:
>> freq-step.c:234:3: error: too few arguments to function âksft_exit_skipâ
>> ksft_exit_skip();
>> ^~~~~~~~~~~~~~
>> In file included from freq-step.c:26:0:
>> ../kselftest.h:142:19: note: declared here
>> static inline int ksft_exit_skip(const char *msg, ...)
>> ^~~~~~~~~~~~~~
>> <builtin>: recipe for target 'freq-step' failed
>> make: *** [freq-step] Error 1
>> [root@s8360046 timers]#
>>
>> This is the case for Intel and s390x. I have not tested other
>> platforms.
>>
>> Which this patch the compilation succeeds:
>
> I think Shuah has already submitted a fix for this to Linus. I
> believe it was merged as 622b2fbe625b.
>
Yes. It has been merged into mainline yesterday for 4.13-rc6
thanks,
-- Shuah