Re: [PATCH 3/3] mfd: d1w: iproc: Add d1w driver

[Scott Branden]

Hi Lee,


On 17-08-17 03:02 AM, Lee Jones wrote:
> On Wed, 16 Aug 2017, Scott Branden wrote:
>
> > From: Shreesha Rajashekar <shreesha@xxxxxxxxxxxx>
> >
> > d1w bus master controller is added as a mfd node.
> Why?
>
> > ds1wm driver is hooked to this node through the mfd framework.
> Why?
It looks like it was added under mfd as htc-pasic3.c is there
(other than htc-pasic3.c is and mfd due to gpio nodes).

Yes, bcm-iproc-d1w should move under w1 directory.
> What makes this an MFD device?
>
> > Signed-off-by: Shreesha Rajashekar <shreesha@xxxxxxxxxxxx>
> > Signed-off-by: Scott Branden <scott.branden@xxxxxxxxxxxx>
> > ---
> >   drivers/mfd/Kconfig         |  11 +++
> >   drivers/mfd/Makefile        |   1 +
> >   drivers/mfd/bcm-iproc-d1w.c | 202 ++++++++++++++++++++++++++++++++++++++++++++
> >   3 files changed, 214 insertions(+)
> >   create mode 100644 drivers/mfd/bcm-iproc-d1w.c