Re: [HMM-v25 19/19] mm/hmm: add new helper to hotplug CDM memory region v3
From: Balbir Singh
Date: Mon Sep 04 2017 - 23:37:02 EST
On Tue, Sep 5, 2017 at 1:51 AM, Jerome Glisse <jglisse@xxxxxxxxxx> wrote:
> On Mon, Sep 04, 2017 at 11:09:14AM +0800, Bob Liu wrote:
>> On 2017/8/17 8:05, JÃrÃme Glisse wrote:
>> > Unlike unaddressable memory, coherent device memory has a real
>> > resource associated with it on the system (as CPU can address
>> > it). Add a new helper to hotplug such memory within the HMM
>> > framework.
>> >
>>
>> Got an new question, coherent device( e.g CCIX) memory are likely reported to OS
>> through ACPI and recognized as NUMA memory node.
>> Then how can their memory be captured and managed by HMM framework?
>>
>
> Only platform that has such memory today is powerpc and it is not reported
> as regular memory by the firmware hence why they need this helper.
>
> I don't think anyone has defined anything yet for x86 and acpi. As this is
> memory on PCIE like interface then i don't expect it to be reported as NUMA
> memory node but as io range like any regular PCIE resources. Device driver
> through capabilities flags would then figure out if the link between the
> device and CPU is CCIX capable if so it can use this helper to hotplug it
> as device memory.
Yep, the arch needs to do the right thing at hotplug time, which is
1. Don't online the memory as a NUMA node
2. Use the HMM-CDM API's to map the memory to ZONE DEVICE via the driver
Like Jerome said and we tried as well, the NUMA approach needs more
agreement and discussion and probable extensions
Balbir Singh