Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq

[Åukasz Majewski]

On 09/06/2017 09:47 PM, Nicolin Chen wrote:
> On Wed, Sep 06, 2017 at 08:35:50PM +0200, Åukasz Majewski wrote:
>   
> > 	clocks = <&clks IMX6QDL_CLK_SSI2_IPG>,
> > 		 <&clks IMX6QDL_CLK_SSI2>;
> > 	clock-names = "ipg", "baud";
>
> > > >   			dailink_master: cpu {
> > > >   			    sound-dai = <&ssi2>;
> > > > 			    clock = <&SSSS>;
> >
> > 	If possible I do prefer a solution, which uses only DTS.
> > Side question - how to refer to baud clock from [1]?
>
> Just add a property to this cpu node like:
> 	clock = <&clks IMX6QDL_CLK_SSI2>;

Ok.

> > > > 			    system-clock-frequency = <XXXX>;
>
> This would not be necessary unless you want to specify a clock rate
> so as to override the clock rate configuration in hw_params().

Ok.

> > > This is the right solution based on current simple-card driver. For
> > > SSI (having two clocks), you have to specify the baud clock in the
> > > cpu node like that. I believe this is what the simple-card designer
> > > expected users to do since the cpu node is the first place that the
> > > driver tries to look at.
> >
> > I will give a shoot the option with adding the ipg clock.
>
> No, not ipg clock. You should use the second clock -- baud clock.

Yes. Correct - the baud clock.

>


--
Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@xxxxxxx