Re: [PATCH v2 21/40] tracing: Generalize per-element hist trigger data

[Tom Zanussi]

On Thu, 2017-09-07 at 13:56 -0400, Steven Rostedt wrote:
> On Tue,  5 Sep 2017 16:57:33 -0500
> Tom Zanussi <tom.zanussi@xxxxxxxxxxxxxxx> wrote:
> 
[...]
> >  	hist_data->map = tracing_map_create(map_bits, hist_data->key_size,
> >  					    map_ops, hist_data);
> > @@ -1724,7 +1722,8 @@ static void hist_trigger_stacktrace_print(struct seq_file *m,
> >  			seq_printf(m, "%s: [%llx] %-55s", field_name,
> >  				   uval, str);
> >  		} else if (key_field->flags & HIST_FIELD_FL_EXECNAME) {
> > -			char *comm = elt->private_data;
> > +			struct hist_elt_data *elt_data = elt->private_data;
> 
> I wonder if we should have a return WARN_ON_ONCE(!elt_data); here just
> in case.
> 

Yeah, that makes sense, as do the other suggestions above, will update.

Thanks,

Tom