Re: [PATCH] netlink: do not proceed if dump's start() errs

[Jason A. Donenfeld]

On Wed, Sep 27, 2017 at 2:39 PM, Jason A. Donenfeld <Jason@xxxxxxxxx> wrote:
> -       if (cb->start)
> -               cb->start(cb);
> +       if (cb->start) {
> +               ret = cb->start(cb);
> +               if (ret)

I need to sock_put(sk); before returning. I'll fix this for v2, but
will for additional comments in case anybody has some.

> +                       return ret;
> +       }
>
>         ret = netlink_dump(sk);
>         sock_put(sk);