Re: [PATCH] netlink: do not proceed if dump's start() errs

[Johannes Berg]

On Wed, 2017-09-27 at 14:50 +0200, Jason A. Donenfeld wrote:
> On Wed, Sep 27, 2017 at 2:39 PM, Jason A. Donenfeld <Jason@xxxxxxxxx>
> wrote:
> > -ÂÂÂÂÂÂÂif (cb->start)
> > -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂcb->start(cb);
> > +ÂÂÂÂÂÂÂif (cb->start) {
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂret = cb->start(cb);
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂif (ret)
> 
> I need to sock_put(sk); before returning. I'll fix this for v2, but
> will for additional comments in case anybody has some.

I guess you could change it to

if (cb->start)
	ret = cb->start(cb);
if (!ret)
	ret = netlink_dump(sk);

johannes