RE: [RESEND PATCH 2/6] staging: fsl-dpaa2/ethsw: Add Freescale DPAA2 Ethernet Switch driver

From: Razvan Stefanescu
Date: Mon Oct 02 2017 - 03:19:05 EST


> -----Original Message-----
> From: Florian Fainelli [mailto:f.fainelli@xxxxxxxxx]
> Sent: Friday, September 29, 2017 19:11
> To: Razvan Stefanescu <razvan.stefanescu@xxxxxxx>; Bogdan Purcareata
> <bogdan.purcareata@xxxxxxx>; gregkh@xxxxxxxxxxxxxxxxxxx
> Cc: devel@xxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx; agraf@xxxxxxx; arnd@xxxxxxxx; Alexandru Marginean
> <alexandru.marginean@xxxxxxx>; Ruxandra Ioana Radulescu
> <ruxandra.radulescu@xxxxxxx>; Laurentiu Tudor <laurentiu.tudor@xxxxxxx>;
> stuyoder@xxxxxxxxx
> Subject: RE: [RESEND PATCH 2/6] staging: fsl-dpaa2/ethsw: Add Freescale DPAA2
> Ethernet Switch driver
>
> On September 29, 2017 6:59:18 AM PDT, Razvan Stefanescu
> <razvan.stefanescu@xxxxxxx> wrote:
> >
> >
> >> -----Original Message-----
> >> From: Bogdan Purcareata
> >> Sent: Friday, September 29, 2017 16:36
> >> To: Razvan Stefanescu <razvan.stefanescu@xxxxxxx>;
> >> gregkh@xxxxxxxxxxxxxxxxxxx
> >> Cc: devel@xxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> >> netdev@xxxxxxxxxxxxxxx; agraf@xxxxxxx; arnd@xxxxxxxx; Alexandru
> >Marginean
> >> <alexandru.marginean@xxxxxxx>; Ruxandra Ioana Radulescu
> >> <ruxandra.radulescu@xxxxxxx>; Laurentiu Tudor
> ><laurentiu.tudor@xxxxxxx>;
> >> stuyoder@xxxxxxxxx
> >> Subject: RE: [RESEND PATCH 2/6] staging: fsl-dpaa2/ethsw: Add
> >Freescale DPAA2
> >> Ethernet Switch driver
> >>
> >> > Introduce the DPAA2 Ethernet Switch driver, which manages Datapath
> >Switch
> >> > (DPSW) objects discovered on the MC bus.
> >> >
> >> > Suggested-by: Alexandru Marginean <alexandru.marginean@xxxxxxx>
> >> > Signed-off-by: Razvan Stefanescu <razvan.stefanescu@xxxxxxx>
>
> This looks pretty good for a new switchdev driver, is there a reason you can't
> target drivers/net/ethernet instead of staging? Is it because the MC bus code is
> still in staging (AFAICT)?
>
Yes, driver depends on MC bus, which is still in staging. Also, control traffic
code will require access to DPIO functions, that are also in staging.

Best regards,
Razvan S.
> --
> Florian