Re: [RESEND PATCH 2/6] staging: fsl-dpaa2/ethsw: Add Freescale DPAA2 Ethernet Switch driver

From: Laurentiu Tudor
Date: Mon Oct 02 2017 - 05:32:41 EST


Hi Florian,

On 09/29/2017 07:11 PM, Florian Fainelli wrote:
> On September 29, 2017 6:59:18 AM PDT, Razvan Stefanescu <razvan.stefanescu@xxxxxxx> wrote:
>>
>>
>>> -----Original Message-----
>>> From: Bogdan Purcareata
>>> Sent: Friday, September 29, 2017 16:36
>>> To: Razvan Stefanescu <razvan.stefanescu@xxxxxxx>;
>>> gregkh@xxxxxxxxxxxxxxxxxxx
>>> Cc: devel@xxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
>>> netdev@xxxxxxxxxxxxxxx; agraf@xxxxxxx; arnd@xxxxxxxx; Alexandru
>> Marginean
>>> <alexandru.marginean@xxxxxxx>; Ruxandra Ioana Radulescu
>>> <ruxandra.radulescu@xxxxxxx>; Laurentiu Tudor
>> <laurentiu.tudor@xxxxxxx>;
>>> stuyoder@xxxxxxxxx
>>> Subject: RE: [RESEND PATCH 2/6] staging: fsl-dpaa2/ethsw: Add
>> Freescale DPAA2
>>> Ethernet Switch driver
>>>
>>>> Introduce the DPAA2 Ethernet Switch driver, which manages Datapath
>> Switch
>>>> (DPSW) objects discovered on the MC bus.
>>>>
>>>> Suggested-by: Alexandru Marginean <alexandru.marginean@xxxxxxx>
>>>> Signed-off-by: Razvan Stefanescu <razvan.stefanescu@xxxxxxx>
>
> This looks pretty good for a new switchdev driver, is there a reason you can't target drivers/net/ethernet instead of staging? Is it because the MC bus code is still in staging (AFAICT)?

There's a pending patch [1] that moves the bus from staging to its place
in drivers/bus. DPIO plus other bits and pieces are next on the list.

Greg,

Just a heads up: if this driver goes in first, then i'll need to re-spin
my patch [1] to also update the #include's in this switch driver.

P.S. Any news on my patch? :-)

[1] https://www.spinics.net/lists/arm-kernel/msg603534.html

---
Thanks, Laurentiu