Re: [PATCH] block/laptop_mode: Convert timers to use timer_setup()

From: Kees Cook
Date: Thu Oct 05 2017 - 14:49:13 EST


On Thu, Oct 5, 2017 at 11:26 AM, Jens Axboe <axboe@xxxxxxxxx> wrote:
> Honestly, I think the change should have waited for 4.15 in that case.
> Why the rush? It wasn't ready for the merge window.

My understanding from my discussion with tglx was that if the API
change waiting for 4.15, then the conversions would have to wait until
4.16. With most conversions only depending on the new API, it seemed
silly to wait another whole release when the work is just waiting to
be merged.

But yes, timing was not ideal. I did try to get it in earlier, but I
think tglx was busy with other concerns.

-Kees

--
Kees Cook
Pixel Security