Re: [PATCH] block/laptop_mode: Convert timers to use timer_setup()

From: Jens Axboe
Date: Thu Oct 05 2017 - 14:56:33 EST

On 10/05/2017 12:49 PM, Kees Cook wrote:
> On Thu, Oct 5, 2017 at 11:26 AM, Jens Axboe <axboe@xxxxxxxxx> wrote:
>> Honestly, I think the change should have waited for 4.15 in that case.
>> Why the rush? It wasn't ready for the merge window.
> My understanding from my discussion with tglx was that if the API
> change waiting for 4.15, then the conversions would have to wait until
> 4.16. With most conversions only depending on the new API, it seemed
> silly to wait another whole release when the work is just waiting to
> be merged.

Right, it would have shifted everything a release. But that's how we do
things! If something isn't ready _before_ the merge window, let alone
talking -rc3 time, then it gets to wait unless it's fixing a regression
introduced in the merge window. Or if you can argue that it's a really
critical fix, sure, it can be squeezed in.

I'm puzzled why anyone would think that this is any different. What I'm
hearing here is that "I didn't want to wait, and my change is more
important than others", as an argument for why this should be treated
any differently.

I'm not saying the change is bad, it looks trivial, from_timer()
discussion aside. But it's not a critical fix, by any stretch of the
imagination, and neither are the driver conversions. With this
additionally causing extra problems because of the timing, that's just
further proof that it should have waited.

> But yes, timing was not ideal. I did try to get it in earlier, but I
> think tglx was busy with other concerns.

So it should have waited...

Jens Axboe