Re: [PATCH 3/6] ARM: sun8i: r40: add 5V regulator for Banana Pi M2 Ultra

From: Maxime Ripard
Date: Mon Oct 09 2017 - 17:04:24 EST


On Sun, Oct 08, 2017 at 04:29:03AM +0000, Icenowy Zheng wrote:
> On newer revisions of the Banana Pi M2 Ultra boards, the 5V power output
> (used by HDMI, SATA and USB) is controller via a GPIO.
>
> Add the regulator node for it.
>
> Older revisions just have the 5V power output always on, and the GPIO is
> reserved on these boards. So it won't affect the older revisions.
>
> Signed-off-by: Icenowy Zheng <icenowy@xxxxxxx>
> ---
> arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
> index 7b52608cebe6..035599d870b9 100644
> --- a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
> +++ b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
> @@ -78,6 +78,15 @@
> };
> };
>
> + reg_vcc5v0: vcc5v0 {
> + compatible = "regulator-fixed";
> + regulator-name = "vcc5v0";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + gpio = <&pio 7 23 GPIO_ACTIVE_HIGH>; /* PH23 */
> + enable-active-high;

This is redundant with the GPIO flag

Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Attachment: signature.asc
Description: PGP signature