[PATCH 4.9 086/105] HID: wacom: leds: Dont try to control the EKRs read-only LEDs

From: Greg Kroah-Hartman
Date: Tue Oct 10 2017 - 15:59:44 EST


4.9-stable review patch. If anyone has any objections, please let me know.

------------------

From: Aaron Armstrong Skomra <skomra@xxxxxxxxx>

commit 74aebed6dc13425233f2224668353cff7a112776 upstream.

Commit a50aac7193f1 introduces 'led.groups' and adds EKR support
for these groups. However, unlike the other devices with LEDs,
the EKR's LEDs are read-only and we shouldn't attempt to control
them in wacom_led_control().

See bug: https://sourceforge.net/p/linuxwacom/bugs/342/

Fixes: a50aac7193f1 ("HID: wacom: leds: dynamically allocate LED groups")
Signed-off-by: Aaron Armstrong Skomra <aaron.skomra@xxxxxxxxx>
Reviewed-by: Jason Gerecke <jason.gerecke@xxxxxxxxx>
Signed-off-by: Jiri Kosina <jkosina@xxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

---
drivers/hid/wacom_sys.c | 3 +++
1 file changed, 3 insertions(+)

--- a/drivers/hid/wacom_sys.c
+++ b/drivers/hid/wacom_sys.c
@@ -712,6 +712,9 @@ static int wacom_led_control(struct waco
if (!wacom->led.groups)
return -ENOTSUPP;

+ if (wacom->wacom_wac.features.type == REMOTE)
+ return -ENOTSUPP;
+
if (wacom->wacom_wac.pid) { /* wireless connected */
report_id = WAC_CMD_WL_LED_CONTROL;
buf_size = 13;