Re: [PATCH 2/2] Add HASH support for Exynos

From: Kamil Konieczny
Date: Tue Oct 17 2017 - 06:32:18 EST




On 17.10.2017 12:07, Krzysztof Kozlowski wrote:
> On Mon, Oct 16, 2017 at 7:43 PM, Kamil Konieczny
> <k.konieczny@xxxxxxxxxxxxxxxxxxx> wrote:
>> Add support for MD5, SHA1, SHA256 hash algorithms for Exynos HW.
>>[...]
>> +#if IS_ENABLED(CONFIG_CRYPTO_DEV_EXYNOS_HASH)
>
> I missed that in v5 because you wrote it is fixed... but it was not.
> You still have #ifdef here. Please fix it:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst#n993

Thank you for link, I didn't get it then, now it is clear,
I will rewrite and send v7 of patch.

--
Best regards,
Kamil Konieczny
Samsung R&D Institute Poland