Re: [PATCH 17/20] staging: lustre: ldlm: mark expected switch fall-through
From: Dilger, Andreas
Date: Tue Oct 17 2017 - 19:02:01 EST
On Oct 12, 2017, at 10:17, Gustavo A. R. Silva <garsilva@xxxxxxxxxxxxxx> wrote:
>
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@xxxxxxxxxxxxxx>
Reviewed-by: Andreas Dilger <andreas.dilger@xxxxxxxxx>
> ---
> drivers/staging/lustre/lustre/ldlm/ldlm_request.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_request.c b/drivers/staging/lustre/lustre/ldlm/ldlm_request.c
> index f3bf238..6943987 100644
> --- a/drivers/staging/lustre/lustre/ldlm/ldlm_request.c
> +++ b/drivers/staging/lustre/lustre/ldlm/ldlm_request.c
> @@ -1175,6 +1175,7 @@ ldlm_cancel_no_wait_policy(struct ldlm_namespace *ns, struct ldlm_lock *lock,
> case LDLM_IBITS:
> if (ns->ns_cancel && ns->ns_cancel(lock) != 0)
> break;
> + /* fall through */
> default:
> result = LDLM_POLICY_SKIP_LOCK;
> lock_res_and_lock(lock);
> --
> 2.7.4
>
Cheers, Andreas
--
Andreas Dilger
Lustre Principal Architect
Intel Corporation