Re: [PATCH 0/2] phy: ti-pipe3: Update PCIe PHY settings

[Kishon Vijay Abraham I]

On Wednesday 18 October 2017 01:01 AM, Bjorn Helgaas wrote:
> On Mon, Oct 09, 2017 at 02:33:36PM +0530, Kishon Vijay Abraham I wrote:
>> This was supposed to only update ti-pipe3 PHY registers. However because
>> of the way the ti-pipe3 PHY, OCP2SCP and PCIe controller are connected
>> in dra7xx where
>>
>> PCIe controller --------------> ti-pipe3 PHY --------------> OCP2SCP
>> 		  depends on		       depends on
>>
>> updating ti-pipe3 PHY registers results in an abort.
>>
>> Though the dependency between ti-pipe3 PHY and OCP2SCP is created
>> (OCP2SCP is parent of ti-pipe3 PHY), and enabling ti-pipe3 PHY clocks
>> should in turn enable OCP2SCP (with the help of pm_runtime framework),
>> this doesn't work in no_irq stage since pm_runtime is disabled during
>> no_irq stage. Since pci-dra7xx enables/initializes ti-pipe3 phy in
>> no_irq stage, OCP2SCP is not enabled resulting in an abort with ti-pipe3
>> PHY registers are accessed.
>>
>> In order to solve this a functional dependency is created between
>> PCIe and ti-pipe3 PHY so that PCIe is suspended before PHY/OCP2SCP
>> and resumed after PCIe PHY/OCP2SCP
>>
>> Kishon Vijay Abraham I (2):
>>   PCI: dwc: dra7xx: Create functional dependency between PCIe and PHY
> 
> s/PCI: dwc: dra7xx: Create functional dependency between PCIe and PHY/
>   PCI: dra7xx: Create functional dependency between PCIe and PHY/
> 
> Should these be merged together?  If it makes sense for you to merge them
> together, here's my ack for the PCI piece:
> 
> Acked-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>

Yeah both should be merged together. I'll make the change you suggested, add
your Ack and merge myself.

Thanks
Kishon