Re: [PATCH] net: rxrpc: mark expected switch fall-throughs

[Gustavo A. R. Silva]

Quoting David Howells <dhowells@xxxxxxxxxx>:

> Gustavo A. R. Silva <garsilva@xxxxxxxxxxxxxx> wrote:
>
> > +		/* fall through */
>
> All new comments in rxrpc should begin with a capital letter; I'm  
> switching to
> this as I modify the lines with comments on.  Fix checkpatch or gcc or
> whatever takes -Wimplicit-fallthrough to stop being silly.
>
> > -		/* Fall through */
> > -
> > +		/* fall through */
>
> No.  Firstly, it should be 'F'; secondly, don't remove the blank line - it's
> there for a reason.

What is the reason?

> > +		/* fall through */
>
> Capital 'F'.
>
> > -
> > +		/* fall through */
>
> Don't remove the blank line.  Capital 'F'.
>
> > +			/* fall through */
>
> Capital 'F'.
>
> David

Thanks
--
Gustavo A. R. Silva