Re: [PATCH net-next] tools: bpftool: add bash completion for bpftool

[David Miller]

From: Jakub Kicinski <jakub.kicinski@xxxxxxxxxxxxx>
Date: Thu, 26 Oct 2017 14:16:05 -0700

> From: Quentin Monnet <quentin.monnet@xxxxxxxxxxxxx>
> 
> Add a completion file for bash. The completion function runs bpftool
> when needed, making it smart enough to help users complete ids or tags
> for eBPF programs and maps currently on the system.
> 
> Update Makefile to install completion file to
> /usr/share/bash-completion/completions when running `make install`.
> 
> Emacs file mode and (at the end) Vim modeline have been added, to keep
> the style in use for most existing bash completion files. In this, it
> differs from tools/perf/perf-completion.sh, which seems to be the only
> other completion file among the kernel sources repository. This is also
> valid for indent style: 4-space indents, as in other completion files.
> 
> Signed-off-by: Quentin Monnet <quentin.monnet@xxxxxxxxxxxxx>
> Signed-off-by: Jakub Kicinski <jakub.kicinski@xxxxxxxxxxxxx>

I'll apply this for now.

If there are major objections I can revert.

Thanks.