Re: [PATCH] mmc: vub300: Use common code in __download_offload_pseudocode()

[Ulf Hansson]

On 30 October 2017 at 13:15, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> On Mon, Oct 30, 2017 at 12:40:39PM +0100, Ulf Hansson wrote:
>> On 27 October 2017 at 21:31, SF Markus Elfring
>> <elfring@xxxxxxxxxxxxxxxxxxxxx> wrote:
>> > From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
>> > Date: Fri, 27 Oct 2017 21:21:40 +0200
>> >
>> > Add a jump target so that a specific string copy operation is stored
>> > only once at the end of this function implementation.
>> > Replace two calls of the function "strncpy" by goto statements.
>> >
>> > This issue was detected by using the Coccinelle software.
>> >
>> > Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
>>
>> Thanks, applied for next!
>>
>
> What's the advantage of this patch?  The new code seems more complicated
> to me and GCC automatically reuses duplicate constant strings so there
> is no memory savings.

It looked to me that the error path got a bit cleaner. However, I
guess it's matter of taste.

If you insist, I can drop it.

Kind regards
Uffe