Re: [RESEND PATCH v2 1/2] soc: amlogic: add Meson GX VPU Domains driver

[Ulf Hansson]

Hi Neil,

[...]

> +
> +       pm_genpd_init(&vpu_hdmi_pd.genpd, &simple_qos_governor,
> +                     meson_gx_pwrc_vpu_get_power(&vpu_hdmi_pd));
> +

This means that you may initialize the genpd in powered on state.

For that scenario, I think you will hit a clock unprepare/disable
in-balance issue when genpd calls your ->power_off() callback, simply
because you didn't call clk_prepare_enable() for the clocks first.

[...]

Kind regards
Uffe