Re: [PATCH V8 2/2] printk: hash addresses printed with %p

[Steven Rostedt]

On Tue, 31 Oct 2017 09:41:02 +1100
"Tobin C. Harding" <me@xxxxxxxx> wrote:


> Cool. So I think we need
> 
>  	get_random_bytes(&ptr_key, sizeof(ptr_key));

You'll need to add a comment here to describe what ordering the memory
barrier is used against. That is, somewhere else there's something that
needs to see the "true" after the "get_random_bytes" update. Describe
it here.

-- Steve


> 	smp_mb();
>  	WRITE_ONCE(have_filled_random_ptr_key, true);
> 
> V10 to include this unless I have it wrong.
> 
> thanks,
> Tobin.