Re: [PATCH] mailbox: add support for doorbell/signal mode controllers

[Bjorn Andersson]

On Wed 01 Nov 11:15 PDT 2017, Sudeep Holla wrote:
> 
>  80         writel_relaxed(msg->cmd, mb->mbox_base +
> MAILBOX_A2B_CMD(chans->idx));
>  81         writel_relaxed(msg->rx_size, mb->mbox_base +
> 
>  82                        MAILBOX_A2B_DAT(chans->idx));
> 
>  83

This is just terrible, using the void *mssg to pass a struct which is
interpreted by the controller removes any form of abstraction provided
by the framework.

In my view the void *mssg should point to the data to be written in the
mailbox register, and hence might be of different size - but only of
native type.

Regards,
Bjorn