Re: [v2] watchdog: pcwd_pci: mark expected switch fall-through

[Guenter Roeck]

On Fri, Nov 03, 2017 at 11:02:30AM -0500, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
> 
> Notice that in this particular case I replaced "Fall" with a proper
> "fall through" comment, which is what GCC is expecting to find.
> 
> Signed-off-by: Gustavo A. R. Silva <garsilva@xxxxxxxxxxxxxx>

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

> ---
> Changes in v2:
>  Place the "fall through" comment outside the unconditional code block.
> 
>  drivers/watchdog/pcwd_pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/pcwd_pci.c b/drivers/watchdog/pcwd_pci.c
> index c0d07ee..1f78f09 100644
> --- a/drivers/watchdog/pcwd_pci.c
> +++ b/drivers/watchdog/pcwd_pci.c
> @@ -545,8 +545,8 @@ static long pcipcwd_ioctl(struct file *file, unsigned int cmd,
>  			return -EINVAL;
>  
>  		pcipcwd_keepalive();
> -		/* Fall */
>  	}
> +		/* fall through */
>  
>  	case WDIOC_GETTIMEOUT:
>  		return put_user(heartbeat, p);