Re: [PATCH v2 3/5] Input: add KEY_ROTATE_LOCK_TOGGLE

From: Bastien Nocera
Date: Thu Nov 09 2017 - 18:35:02 EST


On Thu, 2017-11-09 at 23:44 +0100, Stefan BrÃns wrote:
> The key has the same use as the SW_ROTATE_LOCK, but is used on
> devices
> where the state is not tracked by the hardware but has to be handled
> in software.

I'll let the input and hid subsystem maintainers have the final say
here, though I think that sending out Win+O would be easier, as this is
already something that desktops need to support for those devices that
send the actual Win+O key combination when those buttons are pressed
there.

If we're going with the separate keycode, could you also file bugs
against xkbd-common and xkeyboard-config to get the key added to the
list of XF86 keysyms and to the default evdev keymap? Otherwise Wayland
and X11 based desktops won't be able to use it.

Cheers

> Signed-off-by: Stefan BrÃns <stefan.bruens@xxxxxxxxxxxxxx>
>
> ---
>
> Changes in v2:
> - New patch, add support for KEY_ROTATE_LOCK_TOGGLE
>
> include/uapi/linux/input-event-codes.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/uapi/linux/input-event-codes.h
> b/include/uapi/linux/input-event-codes.h
> index f4058bd4c373..ba5d709a8923 100644
> --- a/include/uapi/linux/input-event-codes.h
> +++ b/include/uapi/linux/input-event-codes.h
> @@ -593,6 +593,7 @@
> #define BTN_DPAD_RIGHT 0x223
>
> #define KEY_ALS_TOGGLE 0x230 /* Ambient light
> sensor */
> +#define KEY_ROTATE_LOCK_TOGGLE 0x231 /* Display
> rotation lock */
>
> #define KEY_BUTTONCONFIG 0x240 /* AL Button
> Configuration */
> #define KEY_TASKMANAGER 0x241 /* AL
> Task/Project Manager */