Re: [PATCH] phy: qcom-ufs: add missing MODULE_DESCRIPTION/LICENSE

From: Bjorn Andersson
Date: Mon Nov 20 2017 - 17:06:56 EST


On Mon 20 Nov 13:33 PST 2017, Jesse Chan wrote:

> This change resolves a new compile-time warning
> when built as a loadable module:
>
> WARNING: modpost: missing MODULE_LICENSE() in drivers/phy/qualcomm/phy-qcom-ufs.o
> see include/linux/module.h for more information
>
> This adds the license as "GPL v2", which matches the header of the file.
>
> MODULE_DESCRIPTION is also added.
>

Acked-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>

Although I suspect that the plan was for the three ufs phy drivers to be
one kernel module...

Regards,
Bjorn

> Signed-off-by: Jesse Chan <jc@xxxxxxxxx>
> ---
> drivers/phy/qualcomm/phy-qcom-ufs.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-ufs.c b/drivers/phy/qualcomm/phy-qcom-ufs.c
> index c5ff4525edef..124dc70f6986 100644
> --- a/drivers/phy/qualcomm/phy-qcom-ufs.c
> +++ b/drivers/phy/qualcomm/phy-qcom-ufs.c
> @@ -675,3 +675,6 @@ int ufs_qcom_phy_power_off(struct phy *generic_phy)
> return 0;
> }
> EXPORT_SYMBOL_GPL(ufs_qcom_phy_power_off);
> +
> +MODULE_DESCRIPTION("Universal Flash Storage (UFS) QCOM PHY");
> +MODULE_LICENSE("GPL v2");
> --
> 2.14.1
>