Re: [PATCH 30/30] PCI: remove pci_get_bus_and_slot() function

From: Greg KH
Date: Wed Nov 22 2017 - 02:51:26 EST

On Wed, Nov 22, 2017 at 12:08:45AM -0600, Timur Tabi wrote:
> On 11/21/17 11:55 PM, Sinan Kaya wrote:
> > For places where domain number information is available, I extracted domain number
> > and added into pci_get_domain_bus_and_slot() call such as xen or bn drivers.
> My suggestion is that you restrict your first patch set to only these
> patches.
> > The assumption at this point is for pci_get_bus_and_slot() usages to be caught
> > in code-review.
> How about this:
> static inline struct pci_dev * __deprecated pci_get_bus_and_slot(unsigned
> int bus,
> unsigned int devfn)
> {
> return pci_get_domain_bus_and_slot(0, bus, devfn);
> }

Ick, no, why? What is wrong with removing this function as is? Don't
mark something as __depreciated if there are no in-kernel users, just
delete it and move on.

If you have out-of-tree drivers, then yes, they can make a wrapper for
this function like this if they really feel the need, or they can get
their code merged :)


greg k-h