Re: [PATCH 30/30] PCI: remove pci_get_bus_and_slot() function

From: Timur Tabi
Date: Wed Nov 22 2017 - 09:42:47 EST

On 11/22/17 1:51 AM, Greg KH wrote:
Ick, no, why? What is wrong with removing this function as is? Don't
mark something as __depreciated if there are no in-kernel users, just
delete it and move on.

If you have out-of-tree drivers, then yes, they can make a wrapper for
this function like this if they really feel the need, or they can get
their code merged:)

Sorry, I guess I should have been clearer. My suggestion was to fix some of the drivers where the domain can be determined, and for the rest, just mark the old function as deprecated.

If that's still a terrible idea, well, okay. I'm just unsure that simply hard-coding a 0 for the domain for some drivers is really a solution. Don't we really want all drivers to properly support all domains?

Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.