Re: [PATCH 30/30] PCI: remove pci_get_bus_and_slot() function

From: Greg KH
Date: Wed Nov 22 2017 - 09:50:03 EST

On Wed, Nov 22, 2017 at 08:42:35AM -0600, Timur Tabi wrote:
> On 11/22/17 1:51 AM, Greg KH wrote:
> > Ick, no, why? What is wrong with removing this function as is? Don't
> > mark something as __depreciated if there are no in-kernel users, just
> > delete it and move on.
> >
> > If you have out-of-tree drivers, then yes, they can make a wrapper for
> > this function like this if they really feel the need, or they can get
> > their code merged:)
> Sorry, I guess I should have been clearer. My suggestion was to fix some of
> the drivers where the domain can be determined, and for the rest, just mark
> the old function as deprecated.

So the build now gets warnings? That's annoying, and then someone else
will have to make the exact same patches that were created here?

> If that's still a terrible idea, well, okay. I'm just unsure that simply
> hard-coding a 0 for the domain for some drivers is really a solution. Don't
> we really want all drivers to properly support all domains?

I bet all of those drivers don't care because they are running only in
systems with 1 domain, otherwise they would be broken today, right? But
really, it shouldn't be that hard to get to the "real" PCI device to
provide the correct pointer to the domain for most of these, as I
pointed out in one patch review already.


greg k-h