Re: [PATCH] MIPS: Validate PR_SET_FP_MODE prctl(2) requests against the ABI of the task

[Maciej W. Rozycki]

Hi Paul,

> >  That written, I could make it 1/2 with the ABI checks becoming 2/2, but 
> > then 1/2 wouldn't make sense on its own (except perhaps as a 
> > microoptimisation, but that would be an entirely different purpose) and 
> > would have to be considered in conjunction with 2/2 anyway.
> 
> Ah - OK, I see. Prior to this patch the value returned by PR_GET_FP_MODE
> would always be one accepted by PR_SET_FP_MODE anyway, but with the
> patch that will cease to be true for non-o32 ABIs without the special
> case. Gotcha.

 And also for !CONFIG_MIPS_O32_FP64_SUPPORT.

> > > Both changes look good to me though, so feel free to add:
> > > 
> > >     Reviewed-by: Paul Burton <paul.burton@xxxxxxxx>
> > 
> >  Thanks for your review.  Do you feel convinced with the justification I 
> > gave?
> 
> Yes - I follow, please consider the Reviewed-by tag valid for the patch
> as-is.

 Great!  Thanks again for your review.

  Maciej