Re: [PATCH v5 1/2] at24: support eeproms that do not auto-rollover reads.

From: Uwe Kleine-König
Date: Thu Dec 07 2017 - 14:03:04 EST


Hello,

On Thu, Dec 07, 2017 at 05:26:50PM +0100, Bartosz Golaszewski wrote:
> > + if (at24->chip.flags & AT24_FLAG_NO_RDROL) {
> > + bits = (at24->chip.flags & AT24_FLAG_ADDR16) ? 16 : 8;
>
> There's no need for braces around the ternary operator's condition.

Even if not required, I'd keep them for clearity.

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |