Re: [PATCH v5 1/2] at24: support eeproms that do not auto-rollover reads.

From: Bartosz Golaszewski
Date: Thu Dec 07 2017 - 16:33:57 EST


2017-12-07 20:02 GMT+01:00 Uwe Kleine-KÃnig <u.kleine-koenig@xxxxxxxxxxxxxx>:
> Hello,
>
> On Thu, Dec 07, 2017 at 05:26:50PM +0100, Bartosz Golaszewski wrote:
>> > + if (at24->chip.flags & AT24_FLAG_NO_RDROL) {
>> > + bits = (at24->chip.flags & AT24_FLAG_ADDR16) ? 16 : 8;
>>
>> There's no need for braces around the ternary operator's condition.
>
> Even if not required, I'd keep them for clearity.
>

I don't want to start bikeshedding, so I'll take it as it is, but I
prefer to avoid braces wherever it's not necessary.

Thanks,
Bartosz