Re: [PATCH v2] KVM: X86: Fix load bad host fpu state

[Wanpeng Li]

2017-12-13 17:59 GMT+08:00 David Hildenbrand <david@xxxxxxxxxx>:
>
>>       if (unlikely(vcpu->arch.mp_state == KVM_MP_STATE_UNINITIALIZED)) {
>> @@ -7709,6 +7706,7 @@ int kvm_arch_vcpu_ioctl_set_fpu(struct kvm_vcpu *vcpu, struct kvm_fpu *fpu)
>>  static void fx_init(struct kvm_vcpu *vcpu)
>>  {
>>       fpstate_init(&vcpu->arch.guest_fpu.state);
>> +     fpstate_init(&vcpu->arch.user_fpu.state);
>
> Won't at least one of them trigger the WARN in fpstate_init?

Nothing trigger the WARN during my testing on a Skylake box. And I
will not continue to push this one since there is an alternative
solution in kvm/queue.

Regards,
Wanpeng Li