Re: [PATCH v2] KVM: X86: Fix load bad host fpu state

[David Hildenbrand]

>  	if (unlikely(vcpu->arch.mp_state == KVM_MP_STATE_UNINITIALIZED)) {
> @@ -7709,6 +7706,7 @@ int kvm_arch_vcpu_ioctl_set_fpu(struct kvm_vcpu *vcpu, struct kvm_fpu *fpu)
>  static void fx_init(struct kvm_vcpu *vcpu)
>  {
>  	fpstate_init(&vcpu->arch.guest_fpu.state);
> +	fpstate_init(&vcpu->arch.user_fpu.state);

Won't at least one of them trigger the WARN in fpstate_init?

>  	if (boot_cpu_has(X86_FEATURE_XSAVES))
>  		vcpu->arch.guest_fpu.state.xsave.header.xcomp_bv =
>  			host_xcr0 | XSTATE_COMPACTION_ENABLED;
> 


-- 

Thanks,

David / dhildenb