Re: [PATCH V4 03/12] drivers: Add boot constraints core

[Viresh Kumar]

On 13-12-17, 10:42, Greg Kroah-Hartman wrote:
> On Sun, Oct 29, 2017 at 07:18:51PM +0530, Viresh Kumar wrote:
> > +	/*
> > +	 * Remove boot constraints for both successful and unsuccessful probe(),
> > +	 * except for the case where EPROBE_DEFER is returned by probe().
> > +	 */
> > +	if (ret != -EPROBE_DEFER)
> > +		dev_boot_constraints_remove(dev);
> 
> This feels odd, but ok, I trust you :)

I did this because it may not be right to keep the boot constraints up for a
device that failed to probe. For example, a LCD screen may continue wasting
power if its device failed to probe. At least I would like to see a real case
where we don't want to remove the constraints here on probe failure.

> > +/* Forward declarations of constraint specific callbacks */
> > +#endif /* _CORE_H */
> 
> What is this comment at the end of the file for?

Perhaps this should be moved to a later patch.

Ack for every other comment you gave.

-- 
viresh