Re: [PATCH v3] Staging: pi433: fix brace coding style issues in pi433_if.c

From: Tomas Marek
Date: Wed Dec 13 2017 - 14:31:25 EST


On 12/13/2017 03:55 AM, Greg KH wrote:

> On Sat, Dec 09, 2017 at 12:41:11PM -0800, Tomas Marek wrote:
>> This patch fix several brace on next line, braces not necessary, space
>> around =/<, and space before/after open/close parenthesis coding style
>> errors find by checkpatch in pi433_if.c.
>>
>> Signed-off-by: Tomas Marek <marek_tomas@xxxxxxxxxx>
>> ---
>> Changes in v3:
>> - DIO0_irq_handler update reverted - will be submitted in separate
>> patch for the sake of clarity.
>> Changes in v2:
>> - DIO0_irq_handler updated - 'if/else if' replaced by 'switch' and
>> 'dev_dbg_ratelimited' used instead of 'dev_dbg' according to Joe
>> Perches suggestion.
>> - The removal of braces around SET_CHECKED() reverted - caused syntax
>> error and is addressed by another patch
>> "[PATCHv2] staging: pi433: pi433_if.c remove SET_CHECKED macro".
> This doesn't apply to my tree at all :(
>
> Please rebase it against the staging-next branch of staging.git (or the
> staging-testing branch to be sure), and then resend.
>
> thanks,
>
> greg k-h
I am sorry for complications. I did it against linux-next. I'll rebase it
against stating and cross-check against staging-testing, hopefully it will
be fine then.

Thank you very much for your patience Greg.

Tomas