RE: [PATCH 1/2] dt-bindings: Document mti,mips-cpc binding
From: Aleksandar Markovic
Date: Mon Dec 18 2017 - 10:39:38 EST
> From: Rob Herring [robh@xxxxxxxxxx]
> Sent: Saturday, December 16, 2017 7:26 PM
> To: Aleksandar Markovic
> Subject: Re: [PATCH 1/2] dt-bindings: Document mti,mips-cpc binding
> On Fri, Dec 15, 2017 at 05:51:59PM +0100, Aleksandar Markovic wrote:
> > From: Paul Burton <paul.burton@xxxxxxxx>
> > Document a binding for the MIPS Cluster Power Controller (CPC) which
> > simply allows the device tree to specify where the CPC registers should
> > be mapped.
> > Signed-off-by: Paul Burton <paul.burton@xxxxxxxx>
> > Signed-off-by: Aleksandar Markovic <aleksandar.markovic@xxxxxxxx>
> > ---
> > Documentation/devicetree/bindings/misc/mti,mips-cpc.txt | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/misc/mti,mips-cpc.txt
> > +++ b/Documentation/devicetree/bindings/misc/mti,mips-cpc.txt
> > @@ -0,0 +1,8 @@
> > +Binding for MIPS Cluster Power Controller (CPC).
> > +
> > +This binding allows a system to specify where the CPC registers should be
> > +mapped using device tree.
> Not really where you map registers, but where they are located.
This will be corrected in the next version.
> > +
> > +Required properties:
> > +compatible : Should be "mti,mips-cpc".
> Only one version of the block?
I am not clear what you mean by "version of the block". I you meant
number of allowed values for *compatible* property, yes, we want and
need just one such value (string).
> > +regs: Should describe the address & size of the CPC register region.
> > --