Re: [PATCH v5 1/2] x86/mm: add a function to check if a pfn is UC/UC-

From: Paolo Bonzini
Date: Tue Dec 19 2017 - 05:42:42 EST


On 19/12/2017 03:40, Haozhong Zhang wrote:
>> As discussed in the reply to v2, this should include WC too. The
>> function name could become something like pat_pfn_downgraded_by_uc_mtrr.
>
> Or shall we just expose lookup_memtype(), and keep all other logic in
> KVM? The function name still looks strange somehow, and the check of
> memory type makes more sense and would be easier to understand in the
> context of KVM.

I agree that it's a bit strange, but I don't want to go against the
suggestions of the x86 maintainer.

Paolo