Re: [PATCH v3] staging: comedi: ni_*: Fix style warnings.

[Greg Kroah-Hartman]

On Thu, Dec 14, 2017 at 01:31:05AM -0600, Aniruddha Shastri wrote:
> Two of these warnings are now line-too-long warnings. I think these 
> warnings are preferable to the ones listed below. The longest line is
> only 85 chars wide, which is reasonable.
> 
> Warnings fixed:
> ni_atmio.c:239: WARNING: Avoid multiple line dereference
> 	- prefer 'ni_boards[i].isapnp_id'
> ni_labpc_common.c:573: WARNING: Avoid multiple line dereference
> 	- prefer 'cmd->scan_begin_arg'
> ni_mio_common.c:736: WARNING: Avoid multiple line dereference
> 	- prefer 'devpriv->counter_dev->counters[gpct_index]'
> ni_mio_common.c:1977: WARNING: Prefer using '"%s...", __func__'
> 	to using 'ni_cmd_set_mite_transfer', this function's name, in a string
> ni_mio_common.c:1990: WARNING: Prefer using '"%s...", __func__'
> 	to using 'ni_cmd_set_mite_transfer', this function's name, in a string
> ni_mio_common.c:4302: WARNING: function definition argument
> 	'int' should also have an identifier name
> ni_mio_common.c:4302: WARNING: function definition argument
> 	'int' should also have an identifier name
> ni_mio_common.c:4302: WARNING: function definition argument
> 	'int *' should also have an identifier name
> ni_mio_common.c:4699: WARNING: Prefer using '"%s...", __func__'
> 	to using 'cs5529_do_conversion', this function's name, in a string
> ni_stc.h:21: WARNING: Block comments should align the * on each line
> 
> Signed-off-by: Aniruddha Shastri <aniruddha.shastri@xxxxxxxxx>
> ---
> Changes in v3:
> No longer add 'const' to sizeof(struct comedi_lrange) in ni_670x.c:212

Please only fix one "type" of issue per patch.  This should be broken up
into multiple patches and sent as a patch series.

thanks,

greg k-h