Re: [PATCH v20 0/7] Virtio-balloon Enhancement
From: Matthew Wilcox
Date: Tue Dec 19 2017 - 09:40:30 EST
On Tue, Dec 19, 2017 at 11:05:11PM +0900, Tetsuo Handa wrote:
> Removing exceptional path made this patch easier to read.
> But what I meant is
> Can you eliminate exception path and fold all xbitmap patches into one, and
> post only one xbitmap patch without virtio-balloon changes?
> I still think we don't need xb_preload()/xb_preload_end().
> I think xb_find_set() has a bug in !node path.
Don't think. Write a test-case. Please. If it shows a bug, then great,
Wei has an example of what the bug is to fix. If it doesn't show a bug,
then we can add it to the test suite anyway, to ensure that case continues
to work in the future.
> Also, please avoid unconditionally adding to builtin modules.
> There are users who want to save even few KB.
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@xxxxxxxxxx For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>