Re: [PATCH 2/4] tpm: delete the TPM_TIS_CLK_ENABLE flag
From: Jason Gunthorpe
Date: Wed Dec 20 2017 - 13:10:20 EST
On Wed, Dec 20, 2017 at 03:19:19PM +0000, Shaikh, Azhar wrote:
> >This flag is only used to warn if CLKRUN_EN wasn't disabled on Braswell
> >systems, but the only way this can happen is if the code is not correct.
> >So it's an unnecessary check that just makes the code harder to read.
> This code was implemented as a suggestion from Jason on the previous patches.
The concept was to be like ASSERT_RTNL, maybe it just needs a suitably
named static inline to addrress Javier's readability concerns?