RE: [PATCH] arm: imx: suspend/resume: use outer_disable/resume

[Peng Fan]

Hi Shawn,

> -----Original Message-----
> From: Shawn Guo [mailto:shawnguo@xxxxxxxxxx]
> Sent: Tuesday, December 26, 2017 5:09 PM
> To: Peng Fan <peng.fan@xxxxxxx>
> Cc: A.s. Dong <aisheng.dong@xxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; Russell
> King <linux@xxxxxxxxxxxxxxx>; van.freenix@xxxxxxxxx; Sascha Hauer
> <kernel@xxxxxxxxxxxxxx>; Fabio Estevam <fabio.estevam@xxxxxxx>; linux-
> arm-kernel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH] arm: imx: suspend/resume: use outer_disable/resume
> 
> On Tue, Dec 26, 2017 at 06:52:45AM +0000, Peng Fan wrote:
> > Hi Shawn,
> >
> > > -----Original Message-----
> > > From: Shawn Guo [mailto:shawnguo@xxxxxxxxxx]
> > > Sent: Tuesday, December 26, 2017 11:31 AM
> > > To: Peng Fan <peng.fan@xxxxxxx>
> > > Cc: A.s. Dong <aisheng.dong@xxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx;
> > > Russell King <linux@xxxxxxxxxxxxxxx>; Fabio Estevam
> > > <fabio.estevam@xxxxxxx>; Sascha Hauer <kernel@xxxxxxxxxxxxxx>;
> > > van.freenix@xxxxxxxxx; linux-arm- kernel@xxxxxxxxxxxxxxxxxxx
> > > Subject: Re: [PATCH] arm: imx: suspend/resume: use
> > > outer_disable/resume
> > >
> > > On Sun, Dec 10, 2017 at 08:07:18PM +0800, Peng Fan wrote:
> > > > Use outer_disable/resume for suspend/resume.
> > > > With the two APIs used, code could be simplified and easy to
> > > > extend to introduce l2c_write_sec for i.MX platforms when moving
> > > > Linux Kernel runs in non-secure world.
> > > >
> > > > Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
> > > > Cc: Shawn Guo <shawnguo@xxxxxxxxxx>
> > > > Cc: Sascha Hauer <kernel@xxxxxxxxxxxxxx>
> > > > Cc: Fabio Estevam <fabio.estevam@xxxxxxx>
> > > > Cc: Russell King <linux@xxxxxxxxxxxxxxx>
> > > > Cc: Dong Aisheng <aisheng.dong@xxxxxxx>
> > > > ---
> > > >  arch/arm/mach-imx/pm-imx6.c      |  2 ++
> > > >  arch/arm/mach-imx/suspend-imx6.S | 24 ------------------------
> > >
> > > I'm fine with the patch in general.  But this piece of code is
> > > running on a few
> > > i.MX6 platforms, and I'm wondering on which SoCs you have verified
> > > the change work fine.
> >
> > I tested it on 6Q-SDB board. Is it ok?
> 
> Okay, I will get it into linux-next for a bit wider testing.

Thanks. I missed to note that, I applied this patch in my testing
https://www.spinics.net/lists/arm-kernel/msg623610.html
to avoid suspicious RCU usage.

Thanks,
Peng.

> 
> Shawn