Re: [PATCH 2/3] objtool: Ignore retpoline alternatives

From: Josh Poimboeuf
Date: Thu Jan 11 2018 - 11:33:55 EST


On Thu, Jan 11, 2018 at 04:27:38PM +0000, David Woodhouse wrote:
> On Wed, 2018-01-10 at 19:48 -0600, Josh Poimboeuf wrote:
> >
> > +#define ANNOTATE_NOSPEC_ALTERNATIVEÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ\
> > +ÂÂÂÂÂÂÂ"999:\n\t"ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ\
> > +ÂÂÂÂÂÂÂ".pushsection .discard.nospec\n\t"ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ\
> > +ÂÂÂÂÂÂÂ".long 999b - .\n\t"ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ\
> > +ÂÂÂÂÂÂÂ".popsection\n\t"
> > +
>
> <mode name="peterz">
> Â Ick, numbers. Use .Lfoo_%= instead.
> </mode>

I seem to recall that not working with inline asm, maybe old versions of
GCC don't like it or something? I can try it and see if 0-day bot
complains.

--
Josh