Re: [PATCH 2/3] objtool: Ignore retpoline alternatives

[David Woodhouse]

On Thu, 2018-01-11 at 10:33 -0600, Josh Poimboeuf wrote:
> On Thu, Jan 11, 2018 at 04:27:38PM +0000, David Woodhouse wrote:
> > 
> > On Wed, 2018-01-10 at 19:48 -0600, Josh Poimboeuf wrote:
> > > 
> > > 
> > > +#define ANNOTATE_NOSPEC_ALTERNATIVEÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ\
> > > +ÂÂÂÂÂÂÂ"999:\n\t"ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ\
> > > +ÂÂÂÂÂÂÂ".pushsection .discard.nospec\n\t"ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ\
> > > +ÂÂÂÂÂÂÂ".long 999b - .\n\t"ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ\
> > > +ÂÂÂÂÂÂÂ".popsection\n\t"
> > > +
> > 
> > Â Ick, numbers. Use .Lfoo_%= instead.
> > 
> I seem to recall that not working with inline asm, maybe old versions of
> GCC don't like it or something?ÂÂI can try it and see if 0-day bot
> complains.

You just need %= (for inline asm) instead of \@ (for .macro).

I already fixed it up in
http://git.infradead.org/users/dwmw2/linux-retpoline.git/Âand will get
nagmail from 0day shortly if it doesn't work :)

(I love you Fengguang)

Attachment: smime.p7s
Description: S/MIME cryptographic signature