checkpatch: Avoid some false positives for TABSTOP declaration test
From: Joe Perches
Date: Thu Jan 11 2018 - 16:01:26 EST
Using an open bracket after what seems to be a declaration
can also be a function definition and declaration argument
line continuation so remove the open bracket from the
possible declaration/definition matching.
e.g.:
int foobar(int a;
int *b[]);
Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
Reported-by: Sven Eckelmann <sven@xxxxxxxxxxxxx>
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index d2464058ab5d..294f03fe25ea 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3020,7 +3020,7 @@ sub process {
# check indentation starts on a tab stop
if ($^V && $^V ge 5.10.0 &&
- $sline =~ /^\+\t+( +)(?:$c90_Keywords\b|\{\s*$|\}\s*(?:else\b|while\b|\s*$)|$Declare\s*$Ident\s*[;=\[])/) {
+ $sline =~ /^\+\t+( +)(?:$c90_Keywords\b|\{\s*$|\}\s*(?:else\b|while\b|\s*$)|$Declare\s*$Ident\s*[;=])/) {
my $indent = length($1);
if ($indent % 8) {
if (WARN("TABSTOP",